T2b Review — REQUEST CHANGES

The root cause diagnosis is correct (PostgREST silently rejects inserts with unknown columns). However, omitting user_address has two downstream consequences:

1. V3.7 in e2e-verify.ts will fail

The verification script checks trade.user_address === results.deployer.toLowerCase() (V3.7). With user_address omitted, this field will be null in Supabase and V3.7 will always fail. Either skip/update V3.7 in the verification script, or add the migration in this PR.

2. Data loss on production trades

user_address tracks who executed the trade — important for user portfolios and trade attribution. Omitting it means all trades indexed before the migration lands will permanently lack this data (unless backfilled).

Recommendation: Add the Supabase migration (ALTER TABLE trade_history ADD COLUMN user_address text;) in this PR rather than deferring it. That way both routes can keep inserting user_address and no data is lost. If you can't run migrations from here, at minimum update e2e-verify.ts V3.7 to handle null user_address.

Verdict: REQUEST CHANGES

Summary

This patch would unblock inserts, but it does so by dropping user_address from trade writes entirely. That regresses a field the current E2E verification explicitly checks, so it does not fully satisfy the trade-indexing acceptance criteria.

Findings

• [high] Removing user_address from trade inserts makes V3.7 fail by design instead of fixing the trade path end-to-end.

  • File: src/app/api/index/trade/route.ts:96
  • Suggestion: add the missing user_address column via migration and keep persisting it, rather than dropping the field from the write path. The current verification script still checks trade.user_address === deployer (scripts/e2e-verify.ts:595), so this workaround only trades the existing V3.2 failure for a guaranteed V3.7 failure.

• [medium] The same regression is duplicated in the cron backfill path, so even after a later migration, historical trades reprocessed through cron would still lose user attribution unless this route is revisited.

  • File: src/app/api/cron/trade-history/route.ts:203
  • Suggestion: keep the backfill path aligned with the API route and land the schema migration as part of this fix set.

Decision

Requesting changes because the proposed workaround persists rows by dropping required trade attribution, which leaves the E2E trade verification incomplete.